Skip to content

麒麟V10测试完成,更新Readme文件 (KylinV10 system test passed)#3

Closed
Guaibaoxiong wants to merge 18 commits into
devfrom
master
Closed

麒麟V10测试完成,更新Readme文件 (KylinV10 system test passed)#3
Guaibaoxiong wants to merge 18 commits into
devfrom
master

Conversation

@Guaibaoxiong

Copy link
Copy Markdown

@JusterZhu JusterZhu closed this Nov 12, 2022
JusterZhu added a commit that referenced this pull request Jun 20, 2026
… glue code, and performance issues

This commit addresses the full audit review of GeneralUpdate.Core:

**Bug fixes:**
- Remove HasExited race condition in WindowsStrategy & MacStrategy (#3,#4)
- Only rollback when no version succeeded yet in AbstractStrategy (#5)
- Guard against null version.Name in DeleteVersionZip (#6)
- Better semaphore timeout logging in DefaultDownloadOrchestrator (#8)
- Robust concurrent-safe DeleteDirectory in StorageManager (#10)
- Add re-entry guard in AbstractStrategy.ExecuteAsync (#11)

**Design improvements:**
- Fix XML doc to match actual validation in UpdateRequest.Validate() (#12)
- Unify SSL policy: VersionService delegates to HttpClientProvider (#16,#17)
- GracefulExit self-shutdown no longer calls Kill() on the current process (#18)
- Use StartsWith instead of IndexOf in BlackMatcher.ShouldSkipDirectory (#19)
- Replace lock with ConcurrentDictionary.GetOrAdd in Option.ValueOf (#20)

**Glue code removal:**
- Extract shared BlackDefaults.CreatePolicyWithDefaults() (#21)
- Remove duplicate CallSmallBowlHomeAsync from Bootstrap (#22)
- Extract shared OsStrategyResolver class (#23)
- Make SafeOnBeforeUpdateAsync semantics consistent: exception = abort (#24)

**Performance:**
- Cache parsed SemVers in DownloadPlanBuilder to avoid repeated parsing (#26)
- Reuse Sha256HashAlgorithm as static field in HashMiddleware (#30)
- Add CleanupOldTempDirectories() to prevent temp directory accumulation (#31)

Co-authored-by: Claude <noreply@anthropic.com>
JusterZhu added a commit that referenced this pull request Jun 20, 2026
… glue code, and performance issues

This commit addresses the full audit review of GeneralUpdate.Core:

**Bug fixes:**
- Remove HasExited race condition in WindowsStrategy & MacStrategy (#3,#4)
- Only rollback when no version succeeded yet in AbstractStrategy (#5)
- Guard against null version.Name in DeleteVersionZip (#6)
- Better semaphore timeout logging in DefaultDownloadOrchestrator (#8)
- Robust concurrent-safe DeleteDirectory in StorageManager (#10)
- Add re-entry guard in AbstractStrategy.ExecuteAsync (#11)

**Design improvements:**
- Fix XML doc to match actual validation in UpdateRequest.Validate() (#12)
- Unify SSL policy: VersionService delegates to HttpClientProvider (#16,#17)
- GracefulExit self-shutdown no longer calls Kill() on the current process (#18)
- Use StartsWith instead of IndexOf in BlackMatcher.ShouldSkipDirectory (#19)
- Replace lock with ConcurrentDictionary.GetOrAdd in Option.ValueOf (#20)

**Glue code removal:**
- Extract shared BlackDefaults.CreatePolicyWithDefaults() (#21)
- Remove duplicate CallSmallBowlHomeAsync from Bootstrap (#22)
- Extract shared OsStrategyResolver class (#23)
- Make SafeOnBeforeUpdateAsync semantics consistent: exception = abort (#24)

**Performance:**
- Cache parsed SemVers in DownloadPlanBuilder to avoid repeated parsing (#26)
- Reuse Sha256HashAlgorithm as static field in HashMiddleware (#30)
- Add CleanupOldTempDirectories() to prevent temp directory accumulation (#31)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants